feat: expose the number of times and the delay between each attempt DHIS2 will try to connect to the database [DHIS2-16091] #15485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15485 +/- ##
============================================
+ Coverage 66.22% 66.23% +0.01%
- Complexity 31240 31244 +4
============================================
Files 3485 3485
Lines 129753 129772 +19
Branches 15141 15141
============================================
+ Hits 85931 85959 +28
+ Misses 36740 36735 -5
+ Partials 7082 7078 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
tonsV2
changed the title
tonsV2
requested review from
Philip-Larsen-Donnelly,
radnov and
stian-sandvold
tonsV2
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
stian-sandvold
approved these changes
Nov 1, 2023
radnov
approved these changes
Nov 1, 2023
Philip-Larsen-Donnelly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to expose this and this property through dhis2.conf.
The reason for exposing the properties is that when we're deploying on Kubernetes, the database and the core are launched at the same time but core runs out of retries before the database is ready.