Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show capture scope enrollments when mode capture [TECH-1635] [2.39] #15532

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

muilpp
Copy link
Contributor

@muilpp muilpp commented Oct 30, 2023

back port of #15518

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #15532 (907e6a3) into 2.39 (886690f) will increase coverage by 6.17%.
Report is 97 commits behind head on 2.39.
The diff coverage is 66.91%.

@@             Coverage Diff              @@
##               2.39   #15532      +/-   ##
============================================
+ Coverage     58.58%   64.76%   +6.17%     
- Complexity    25817    28678    +2861     
============================================
  Files          3207     3212       +5     
  Lines        121397   121827     +430     
  Branches      14158    14217      +59     
============================================
+ Hits          71118    78896    +7778     
+ Misses        44340    36449    -7891     
- Partials       5939     6482     +543     
Flag Coverage Δ
integration 48.56% <30.06%> (-0.04%) ⬇️
integration-h2 33.99% <24.00%> (?)
unit 29.56% <41.12%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...main/java/org/hisp/dhis/appmanager/AppManager.java 100.00% <ø> (ø)
...src/main/java/org/hisp/dhis/category/Category.java 65.21% <100.00%> (ø)
...ava/org/hisp/dhis/common/BaseAnalyticalObject.java 70.95% <100.00%> (+5.81%) ⬆️
...a/org/hisp/dhis/common/BaseIdentifiableObject.java 80.20% <100.00%> (+1.37%) ⬆️
...s-api/src/main/java/org/hisp/dhis/common/Grid.java 0.00% <ø> (ø)
.../src/main/java/org/hisp/dhis/common/QueryItem.java 68.66% <100.00%> (ø)
...isp/dhis/dataapproval/DataApprovalPermissions.java 91.66% <ø> (+22.43%) ⬆️
...rc/main/java/org/hisp/dhis/feedback/ErrorCode.java 100.00% <100.00%> (ø)
...src/main/java/org/hisp/dhis/period/PeriodType.java 85.45% <100.00%> (+1.91%) ⬆️
...rg/hisp/dhis/resourcetable/ResourceTableStore.java 100.00% <ø> (+100.00%) ⬆️
... and 97 more

... and 552 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb2546...907e6a3. Read the comment docs.

@muilpp muilpp requested review from enricocolasante and a team October 30, 2023 09:13
@muilpp muilpp marked this pull request as ready for review October 30, 2023 09:14
@muilpp muilpp enabled auto-merge (squash) October 30, 2023 09:17
@muilpp muilpp merged commit ce92ce1 into 2.39 Oct 30, 2023
12 checks passed
@muilpp muilpp deleted the TECH-1635-capture-mode-in-enrollments_2.39 branch October 30, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants