chore: Rename executionDate to occurredDate in service layer [TECH-1615] #15557

enricocolasante · 2023-11-01T10:32:57Z

occurredAt field in Event was internally translated to eventDate or executionDate.
This PR aims to replace all occurrences of eventDate and executionDate in the service layer to occurredDate.
The general rule that we are using is that date fields are suffixed with At in the API and then suffixed with Date in the service and the DB layer.

This PR is also renaming the parameters chain (not changes are done to the API) for the event exporter to filter by occurredAt field (occurredAfter and occurredBefore)

Next PRs

Rename scheduledAt in service layer
Rename occurredAt in DB layer
Rename scheduledAt in DB layer

codecov · 2023-11-01T10:51:05Z

Codecov Report

Merging #15557 (3b97ae4) into master (60ec85e) will increase coverage by 0.00%.
The diff coverage is 81.39%.

@@            Coverage Diff            @@
##             master   #15557   +/-   ##
=========================================
  Coverage     66.22%   66.23%           
- Complexity    31240    31244    +4     
=========================================
  Files          3485     3485           
  Lines        129753   129754    +1     
  Branches      15141    15141           
=========================================
+ Hits          85931    85937    +6     
+ Misses        36740    36739    -1     
+ Partials       7082     7078    -4

Flag	Coverage Δ
integration	`49.77% <69.76%> (+<0.01%)`	⬆️
integration-h2	`32.42% <13.95%> (-0.01%)`	⬇️
unit	`30.33% <44.18%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...api/src/main/java/org/hisp/dhis/program/Event.java	`95.60% <100.00%> (ø)`
...ation/ProgramStageNotificationMessageRenderer.java	`75.71% <100.00%> (ø)`
...sp/dhis/program/hibernate/HibernateEventStore.java	`65.78% <ø> (ø)`
...hisp/dhis/sms/listener/CompressionSMSListener.java	`72.66% <100.00%> (ø)`
.../dxf2/deprecated/tracker/event/JdbcEventStore.java	`49.29% <100.00%> (ø)`
...importer/context/ProgramStageInstanceSupplier.java	`93.22% <100.00%> (ø)`
...er/importer/mapper/ProgramStageInstanceMapper.java	`92.77% <100.00%> (ø)`
...rocess/ProgramStageInstanceUpdatePreProcessor.java	`77.50% <100.00%> (ø)`
...mporter/update/validation/ExpirationDaysCheck.java	`76.00% <100.00%> (ø)`
.../engine/DefaultProgramRuleEntityMapperService.java	`79.03% <100.00%> (ø)`
... and 16 more

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ec85e...3b97ae4. Read the comment docs.