-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support for Hikari pool metrics [DHIS2-15419] #15623
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15623 +/- ##
=========================================
Coverage 66.23% 66.23%
- Complexity 31250 31264 +14
=========================================
Files 3485 3487 +2
Lines 129791 129811 +20
Branches 15145 15146 +1
=========================================
+ Hits 85965 85980 +15
- Misses 36741 36748 +7
+ Partials 7085 7083 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
...pport-system/src/main/java/org/hisp/dhis/monitoring/metrics/jdbc/HikariMetadataProvider.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
* fix: add support for Hikari pool metrics (cherry picked from commit 94e33c8)
* fix: add support for Hikari pool metrics (cherry picked from commit 94e33c8)
Summary
monitoring.dbpool.enabled = on
, when also the Hikari pool is enabled with the propertydb.pool.type = hikari
, would cause the server failing to start.JIRA:
DHIS2-15419