fix: Close database connection after test statement. #15640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #15640 +/- ##
============================================
- Coverage 66.20% 66.20% -0.01%
+ Complexity 31264 31261 -3
============================================
Files 3487 3487
Lines 129902 129905 +3
Branches 15170 15170
============================================
- Hits 86007 86004 -3
- Misses 36813 36816 +3
- Partials 7082 7085 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jbee
approved these changes
Nov 13, 2023
jason-p-pickering
added a commit
that referenced
this pull request
Nov 13, 2023
* fix: Close database connection after test statement.
jason-p-pickering
added a commit
that referenced
this pull request
Nov 13, 2023
* fix: Close database connection after test statement.
jason-p-pickering
added a commit
that referenced
this pull request
Nov 14, 2023
jason-p-pickering
added a commit
that referenced
this pull request
Nov 14, 2023
jason-p-pickering
added a commit
that referenced
this pull request
Nov 14, 2023
* fix: Close database connection after test statement.
jason-p-pickering
added a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the try-resource pattern to automatically close the database connection during startup.