New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rename incidentDate to occurredDate in service layer [TECH-1665] #15685

Merged

enricocolasante merged 2 commits into master from TECH-1665

Nov 15, 2023

Contributor

enricocolasante commented Nov 14, 2023 •

edited

Loading

occurredAt field in Enrollment was internally translated to incidentDate.
This PR aims to replace all occurrences of incidentDate in the service layer to occurredDate.
The general rule that we are using is that date fields are suffixed with At in the API and then suffixed with Date in the service and the DB layer.

Next PRs

Rename completedAt in DB layer
Rename occurredAt in DB layer

enricocolasante added 2 commits

November 14, 2023 13:15


          chore: Rename incidentDate to occurredDate in service layer [TECH-1665]

1dd1bd6


          Fix tests

5817b04

sonarqubecloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

enricocolasante requested review from muilpp, abyot, lucaCambi77 and zubaira

November 14, 2023 14:09

enricocolasante enabled auto-merge (squash)

November 14, 2023 14:10

muilpp approved these changes

View reviewed changes

enricocolasante disabled auto-merge

November 15, 2023 08:15

enricocolasante merged commit 0adbc6a into master

16 checks passed

enricocolasante deleted the TECH-1665 branch

November 15, 2023 08:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet