backport: Use try-with-resources to close BatchHandler #15704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use try-with-resources to close BatchHandler * Rework test to deal with multi-threading * Add try-catch to Analytics table manager
david-mackessy
approved these changes
Nov 15, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.39 #15704 +/- ##
============================================
+ Coverage 58.58% 64.77% +6.18%
- Complexity 25817 28693 +2876
============================================
Files 3207 3212 +5
Lines 121397 121821 +424
Branches 14158 14221 +63
============================================
+ Hits 71118 78907 +7789
+ Misses 44340 36427 -7913
- Partials 5939 6487 +548
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 543 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jason-p-pickering
deleted the
fix/batch-handler-try-with-resources_2.39
branch
jason-p-pickering
added a commit
that referenced
this pull request
Nov 16, 2023
jason-p-pickering
added a commit
that referenced
this pull request
Nov 16, 2023
jason-p-pickering
added a commit
that referenced
this pull request
Nov 16, 2023
jason-p-pickering
added a commit
that referenced
this pull request
Nov 16, 2023
jason-p-pickering
added a commit
that referenced
this pull request
Nov 16, 2023
* fix: always flush the batch handler for CompleteDataSet import [DHIS2-15362] (2.39) (#15625) * fix: always flush the batch handler for CompleteDataSet import [DHIS2-15362] * fix: test setup * fix: controller imports use interface not impl * Use try-with-resources to close BatchHandler (#15661) (#15704) * Use try-with-resources to close BatchHandler * Rework test to deal with multi-threading * Add try-catch to Analytics table manager --------- Co-authored-by: Jan Bernitt <[email protected]>
jason-p-pickering
added a commit
that referenced
this pull request
Nov 16, 2023
* fix: always flush the batch handler for CompleteDataSet import [DHIS2-15362] (2.39) (#15625) (#15710) * fix: always flush the batch handler for CompleteDataSet import [DHIS2-15362] * fix: test setup * fix: controller imports use interface not impl * Use try-with-resources to close BatchHandler (#15661) (#15704) (#15711) * Use try-with-resources to close BatchHandler * Rework test to deal with multi-threading * Add try-catch to Analytics table manager --------- Co-authored-by: Jan Bernitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15661