fix: program indicator aggregation for TEI [DHIS2-13779] #15769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #15769 +/- ##
============================================
- Coverage 66.31% 66.28% -0.04%
- Complexity 31374 31417 +43
============================================
Files 3481 3492 +11
Lines 129925 130164 +239
Branches 15197 15214 +17
============================================
+ Hits 86162 86274 +112
- Misses 36672 36795 +123
- Partials 7091 7095 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 29 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
d-bernat
approved these changes
Nov 24, 2023
| String function = programIndicatorQueryParts.function(); | ||
| String expression = programIndicatorQueryParts.expression(); | ||
|
|
||
| String condition = "1=1"; |
There was a problem hiding this comment.
As discussed, would be nice to avoid it.
maikelarabori
approved these changes
Nov 24, 2023
|
Kudos, SonarCloud Quality Gate passed! |
maikelarabori
added
run-api-analytics-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.