fix: only restrict set of checks when executing them [DHIS2-16256] #15840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #15840 +/- ##
=========================================
Coverage 66.36% 66.37%
- Complexity 31428 31435 +7
=========================================
Files 3487 3487
Lines 130028 130029 +1
Branches 15183 15183
=========================================
+ Hits 86294 86302 +8
+ Misses 36648 36645 -3
+ Partials 7086 7082 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jbee
commented
Dec 6, 2023
...t/java/org/hisp/dhis/webapi/controller/dataintegrity/DataIntegritySummaryControllerTest.java
Outdated
Show resolved
Hide resolved
david-mackessy
approved these changes
Dec 6, 2023
jason-p-pickering
approved these changes
Dec 6, 2023
|
Kudos, SonarCloud Quality Gate passed! |
jbee
added a commit
to jbee/dhis2-core
that referenced
this pull request
Dec 6, 2023
…his2#15840) * fix: only restrict set of checks when executing them [DHIS2-16256] * test: show that slow tests are included in summary [DHIS2-16256]
jbee
added a commit
to jbee/dhis2-core
that referenced
this pull request
Dec 6, 2023
…his2#15840) * fix: only restrict set of checks when executing them [DHIS2-16256] * test: show that slow tests are included in summary [DHIS2-16256]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When executing data integrity checks the default (no set of checks was explicitly specified) is to only run checks that are not marked as "slow". This filter wrongly was also used when expanding checks to read the results from the cache. This meant that slow checks would not be included unless explicitly named.
Automatic Testing
Modified existing tests with additional checks that verify that reading check descriptions and check summaries after execution does include the slow checks which means they are not filtered.
Manual Testing
/api/dataIntegrity/summary(nochecksparameter to run all defaults)/api/dataIntegrity/summary?checks=data_elements_aggregate_abandoned/api/dataIntegrity/summaryshould include the slow checkdata_elements_aggregate_abandoned