fix: Nepali calendar support #19438
Open
fix: Nepali calendar support #19438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abyot
commented
Dec 11, 2024
abyot
commented
- ISO period names should match Nepali calendar. Baisakh 2081 is 208101 not 202404
- Fix to weekly periods start and end dates
There was a problem hiding this comment.
Thanks for the changes @abyot, I left some questions and suggestions.
Please, take a look... thanks!
| /* | ||
| * https://en.m.wikipedia.org/wiki/ISO_week_date | ||
| */ | ||
| int week = (10 + getDayOfYear(dateTimeUnit) - isoWeekday(dateTimeUnit)) / 7; |
There was a problem hiding this comment.
Could you add constants to the integers here?
Also, a Javadoc would be nice. The Wikipedia website can be left as a reference.
| toIso(dateTimeUnit).toJodaDateTime(ISOChronology.getInstance(DateTimeZone.getDefault())); | ||
| return dateTime.getDayOfWeek(); | ||
| /* | ||
| * calculating week day from calendar dateTimeUnit is best managed |
There was a problem hiding this comment.
Suggested change
| * calculating week day from calendar dateTimeUnit is best managed | |
| * Calculating week day from calendar dateTimeUnit is best managed |
| @@ -475,6 +500,39 @@ private DateInterval toDayIsoInterval(DateTimeUnit dateTimeUnit, int offset, int | |||
| private static final Map<Integer, int[]> CONVERSION_MAP = new HashMap<>(); | |||
There was a problem hiding this comment.
Can you add a comment, so we know until which year this is valid?
I belive that at some point we need to add more elements to the map...?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.