Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minor changes to email verification #19494

Merged
merged 4 commits into from
Dec 17, 2024
Merged

feat: minor changes to email verification #19494

merged 4 commits into from
Dec 17, 2024

Conversation

netroms
Copy link
Contributor

@netroms netroms commented Dec 16, 2024

Summary

Minor tweaks to the email verification feature.

  • Set redirect after success URL: /dhis-web-login/#/email-verification-success
  • Sett redirect after failure URL: /dhis-web-login/#/email-verification-failure
  • Add user's emailVerified property into /me endpoint
  • Change redirect when enforce email is enabled to: https://play.im.dhis2.org/dev/dhis-web-user-profile/#/profile
  • Change the error msg when email verification email can’t be sent. It’s a bit too technical, remove the word “token” replace with more user friendly msg

Tests

  • LoginTest#verifyEmailWithToken() (Redirect on email verification success)
  • LoginTest#redirectAfterEmailVerificationFailure() (Redirect on email verification failure)
  • LoginTest#testRedirectAccountWhenVerifiedEmailEnforced() (Redirect when enforce email is enabled)
  • MeControllerTest#testGetEmailVerifiedProperty() (Show emailVerified in me endpoint)

@netroms netroms merged commit 402e2b7 into master Dec 17, 2024
17 checks passed
@netroms netroms deleted the DHIS2-18623_2.42 branch December 17, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants