fix: Always add default order as last order param in tracker exporters [DHIS2-18659] #19551
+120
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
muilpp
approved these changes
Dec 20, 2024
ameenhere
reviewed
Dec 20, 2024
| @@ -279,7 +279,7 @@ private static String orderBy(List<Order> orders) { | |||
| orderJoiner.add( | |||
| order.getField() + " " + (order.getDirection().isAscending() ? "asc" : "desc")); | |||
| } | |||
| return " order by " + orderJoiner; | |||
| return " order by " + orderJoiner + ", " + DEFAULT_ORDER; | |||
There was a problem hiding this comment.
I guess there is no consequence if the same DEFAULT_ORDER is also part of the orderJoiner?
There was a problem hiding this comment.
Default order, aka entity id, it is not part of orderable fields, so it cannot ever be part of the orderJoiner here
ameenhere
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always add default order as a last order parameter to have a consistent order between results.