feat: support new dashboard plugin architecture #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-396.line-listing.netlify.dhis2.org |
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
b365999 to
e156657
Compare
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
795334d to
16060c2
Compare
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
16060c2 to
ea99422
Compare
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
dc5c207 to
af32223
Compare
edoardo
changed the title
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
af32223 to
3ed21de
Compare
edoardo
added
the
e2e record
line-listing-app
|
||||||||||||||||||||||||||||
| Project |
line-listing-app
|
| Branch Review |
refactor/use-platform-plugin-components
|
| Run status |
|
| Run duration | 11m 04s |
| Commit |
|
| Committer | Edoardo Sabadelli |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
588
|
| View all changes introduced in this branch ↗︎ | |
5 tasks
edoardo
changed the title
There were issues with tooltip Cypress tests after upgrading @dhis2/ui. Most likely because now the Tooltip stays open until a mouseout event occours and this can cover an element which is targeted for another test. The Esc key can also be used to close it, and this is what this change is doing.
The default behaviour has a small delay, which causes Tooltip to linger around for a while and appearing on top of other elements (like modals) which is not desirable.
This fixes a bug where the tooltip show date ranges in different formats when changing the range and updating the visualization.
HendrikThePendric
approved these changes
Nov 18, 2024
…rm-plugin-components
…rm-plugin-components
edoardo
removed
the
e2e record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for: DHIS2-17268
Requires dhis2/analytics#1672
Key features
Description
Generic components for plugins are available in
app-platformandapp-runtime.Analytics apps are currently having the same components replicated in each repo, a shared dashboard plugin wrapper has been added in
analytics.Known issues
Screenshots