Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Android, use FragmentActivity instead of AppCompatActivity #92

Merged
merged 1 commit into from
Apr 8, 2024
Merged

On Android, use FragmentActivity instead of AppCompatActivity #92

merged 1 commit into from
Apr 8, 2024

Conversation

pmerlet-at-didomi
Copy link
Contributor

@pmerlet-at-didomi pmerlet-at-didomi commented Apr 5, 2024 •
edited
Loading

Instead of modifying UnityPlayerActivity into a AppCompatActivity, use FragmentActivity, as AppCompatActivity is no longer needed by native sdk.

This activity class has far less constraints, which allows us to get rid of post-processing modifications done to the app style.

@pmerlet-at-didomi
Copy link
Contributor Author

Should fix issue #90

@pmerlet-at-didomi pmerlet-at-didomi merged commit d94c60f into master Apr 8, 2024
@pmerlet-at-didomi pmerlet-at-didomi deleted the feat/use-fragment-activity branch April 8, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipe-saez felipe-saez felipe-saez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmerlet-at-didomi @felipe-saez