Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥✨ Regenerate cloudcontroller with up-to-date python (asyncio) openapi generator #114

Merged
merged 121 commits into from
Oct 20, 2023

Conversation

ff137
Copy link
Collaborator

@ff137 ff137 commented Oct 11, 2023

This deprecates our usage of our custom python-uplink openapi-generator that was written 2 years ago.

💥 Breaking changes:

  • Pydantic 1 -> 2
  • some models now expect strict types as input
  • some model fields renamed (for fields that are reserved words: schema_ renamed to var_schema and from_ to var_from)

✨ New features:

  • Replaced uplink (unmaintained, with deprecated dependencies - and which used a threading approach to request) with asyncio, which uses more efficient asynchronous HTTP requests.
  • Added methods to allow fetching wallets by group id -- used with our ACA-Py plugin: didx-xyz/acapy-wallet-groups-plugin
  • autoflake + isort + black added to generate-client.sh script to clean up and organise autogenerated code, and improved ease of auto-generating client by adding automatic post-processing steps

Notes:

  • Multitenancy API create and fetch wallet methods now supports our wallet group_id plugin
  • JsonLD verify request body circumvents problematic model validation in ACA-Py (todo: post issue)
  • boolean query parameters need to be preprocessed (from booleans to strings) to work with ACA-Py. This was previously done at each method using boolean params. Now configured in the rest API client

ff137 added 30 commits October 10, 2023 14:05
…stprocess generated client with autoflake, black, and isort
@ff137 ff137 force-pushed the feat/update-openapi-generator branch from fda8a85 to d186f74 Compare October 18, 2023 14:27
rblaine95
rblaine95 previously approved these changes Oct 20, 2023
Copy link
Collaborator

@rblaine95 rblaine95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what my review is worth, LGTM 👍
Well done!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
19.1% 19.1% Duplication

@ff137 ff137 merged commit bfc0f04 into main Oct 20, 2023
4 of 5 checks passed
@ff137 ff137 deleted the feat/update-openapi-generator branch October 20, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants