Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Accounts Controllers Validators #125

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

gabriellopes00
Copy link
Contributor

I've completely removed RequiredFieldsValidator, CompareFieldsValidator and ValidatorCompositor as proposed on issue #72, and implemented the validators by controller using yup library, as suggested.

I had some issues because package.json and yarn.lock files conflicted due the long time of the fork, some libraries have updated... but is already solved.

The error messages adapter is already created, but it's under development and isn't been applied yet, but the validators themselves are working very well.

If approved, I'll keep implementing the others validators following the same pattern.

@gabriellopes00
Copy link
Contributor Author

gabriellopes00 commented Aug 30, 2021

I've updated package.json and yarn.lock files, cause u updated some dependencies...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant