Update ArrayMap

[hssahota2]

No description provided.

[nedtwigg]

Good work, but two problems:

• Comparable doesn't work with Python
• it's better to centralize all the binarySearch into ListBackedSet, no reason to spread it around

[nedtwigg]

Closer!

[nedtwigg]

Excellent! Much improved, I think this is the last change and ArrayMap will be done!

[nedtwigg]

1. since we're in Python, this doesn't have to be in a class. It could just be def _binary_search_util(data, item):

2. This function is only ever called with two parameters -compare_func is always None. The fix is

def _compare_normal(a, b) -> int:
  if a == b:
    return 0
  else if a < b:
    return -1
  else
    return 1

def _compare_string_slash_first(a: str, b : str) -> int:
  return _compare_normal(a.replace("/", "\0"), b.replace("/", "\0"))

def _binary_search(data, item) -> int:
  compare_func = _compare_string_slash_first if item is str else _compare_normal
  low, high = 0, len(data) - 1
  ...
  the rest of the logic, but now you know that compare_func is never None