remove env vars that are not used in this repo

digicatapult · Oct 9, 2024 · a40a8a0 · a40a8a0
1 parent 36622ae
commit a40a8a0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -17,15 +17,12 @@ The following environment variables can be set:
 | Variable                       | Default Value                    | Description                                   |
 |--------------------------------|----------------------------------|-----------------------------------------------|
 | MLFLOW_TRACKING_URI            | `http://localhost:8080`          | The URI for the MLflow tracking server        |
+| MLFLOW_TRACKING_USERNAME       | None                             | MLFlow tracking username                      | 
+| MLFLOW_TRACKING_PASSWORD       | None                             | MLFlow tracking password                      | 
 | DEPLOY_MODEL_NAME              | `house_price_prediction_prod`    | The name of the model to be deployed          |
 | DEPLOY_MODEL_ALIAS             | `champion`                       | The alias for the deployed model              |
-| DOCKER_REGISTRY                | `localhost:5000`                 | The Docker registry where images are stored   |
-| MLFLOW_BUILT_IMAGE_NAME        | `mlflow_model`                   | The name of the MLflow model Docker image     |
-| MLFLOW_BUILT_IMAGE_TAG         | `latest`                         | The tag for the MLflow model Docker image     |
 | MODEL_DOCKER_BUILD_CONTEXT_PVC | `model_docker_build_context_pvc` | Name of the PVC allocated for this DAG        |
-| MODEL_DOCKER_PUSH_SECRET       | `ecr-credentials`                | Name of the secret to authenticate ECR access | 
-| MLFLOW_TRACKING_USERNAME       | None                             | MLFlow tracking username                      | 
-| MLFLOW_TRACKING_PASSWORD       | None                             | MLFlow tracking password                      | 
+| MODEL_DOCKER_PUSH_SECRET       | `ecr-credentials`                | Name of the secret to authenticate ECR access |
 
 
 

diff --git a/src/utils.py b/src/utils.py
@@ -17,9 +17,6 @@ class Envs(BaseSettings):
     mlflow_tracking_uri: str = "http://localhost:8080"
     deploy_model_name: str = "house_price_prediction_prod"
     deploy_model_alias: str = "champion"
-    docker_registry: str = "localhost:5000"
-    mlflow_built_image_name: str = "mlflow_model"
-    mlflow_built_image_tag: str = "latest"
     mlflow_docker_out_dir: str = "./mlflow-dockerfile"
     mlflow_tracking_username: str | None = None
     mlflow_tracking_password: str | None = None