Cache project #837
Merged
Cache project #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for madoc-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stephenwf
commented
Nov 26, 2024
Comment on lines
+33
to
+40
| if (Object.keys(slowRequestStore).length > 50) { | ||
| // Sort by slowest. | ||
| const sorted = Object.values(slowRequestStore).sort((a, b) => b.slowest - a.slowest); | ||
| const slowest = sorted.pop(); | ||
| if (slowest && slowest.key) { | ||
| delete slowRequestStore[slowest.key]; | ||
| } | ||
| } |
There was a problem hiding this comment.
This isn't ideal, but it prevents looping every entry on line 23. There is a finite number route too - so if it is a problem it can be removed completely.
|
Preview docker image available |
stephenwf
commented
Nov 26, 2024
Comment on lines
+36
to
+37
| cache.put(key, result, timeInMs); | ||
| cache.put(`@stale/${key}`, result, staleTimeInMs); |
There was a problem hiding this comment.
I checked the source code of memory-cache. It doesn't copy the result, so the extra memory to keep a stale copy is only the size of the key. The memory is released when you put the stale copy. It will mean that for infrequent requests we will hold onto stale data for longer. I've set it to 8 hours for now. (The service will also restart the node process if max memory is reached).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 3 features:
The request trace is visible on the System page in the admin.
It can be disabled with the environment variable flag:
DISABLE_SLOW_REQUEST_TRACKING=true