Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional language colors #2858

Closed
3 tasks
JoeyStk opened this issue Jun 18, 2024 · 20 comments · Fixed by #3240
Closed
3 tasks

Add additional language colors #2858

JoeyStk opened this issue Jun 18, 2024 · 20 comments · Fixed by #3240
Assignees
Labels
effort: low Should be doable in <4h feature New feature or request good first issue Good for newcomers tested Was successfully tested on cms-test
Milestone

Comments

@JoeyStk
Copy link
Contributor

JoeyStk commented Jun 18, 2024

Motivation

We have added colors for languages. But currently we don't have colors for four languages. As soon as UI/UX provides them, please add them to the system.
Additionally UI/UX will give us some extra colors, which we also want to add to the system and just not assign them to a language (yet).

Proposed Solution

  • Look up the name of colors that were provided
  • Add colors to the system

Todos:

  • Add language colors for Georgian, Slovak, Serbian (cyrillic) and Oromo (for Integreat)
  • Add language colors for Paschto, Uzbek and Macedonian (for Malte)
  • Add some buffer language colors for yet unspecified languages

Alternatives

None

User Story

Additional Context

Design Requirements

@JoeyStk JoeyStk added feature New feature or request good first issue Good for newcomers ui-ux Issues that requires an UI/UX perspective. blocked Blocked by external dependency effort: low Should be doable in <4h labels Jun 18, 2024
@JoeyStk JoeyStk added this to the 24Q3 milestone Jun 18, 2024
@lunars97 lunars97 self-assigned this Jun 20, 2024
@MizukiTemma
Copy link
Member

Those languages exist in Integreat and are waiting for color assignment:

  • Georgian
  • Oromo
  • Slovak
  • Serbian (cyrillic)

Additionally those languages need colors for Malthe:

  • Mazedonisch
  • Paschto
  • Usbekisch

@nassabay Feel free to add informations and comments 😸

@nassabay
Copy link

nassabay commented Jul 1, 2024

Just to add that Serbian has the same colour as Russian: Purple. Maybe it would be a good idea to choose another colour for Serbian.

@JoeyStk JoeyStk removed ui-ux Issues that requires an UI/UX perspective. blocked Blocked by external dependency labels Jul 2, 2024
@JoeyStk
Copy link
Contributor Author

JoeyStk commented Jul 2, 2024

The colors for Oromo, Slovak, Servian (cyrillic) and Georgian can be found here

@JoeyStk JoeyStk added the ui-ux Issues that requires an UI/UX perspective. label Jul 2, 2024
@lunars97
Copy link
Contributor

lunars97 commented Jul 22, 2024

@nassabay @MizukiTemma there is a suggestion from UI/UX team, @hauf-toni? Does it make sense then to implement this issue? Maybe it is better to close this current Issue and open another one like suggested below in Figma? 🤔
image

@lunars97 lunars97 added the question Further information is requested label Jul 22, 2024
@hauf-toni
Copy link

the colors should definitely be implemented. at the same time, the function of being able to set colors yourself would be super important due to the circumstances described above & should be introduced as soon as possible. do you need a design proposal for this?

@lunars97
Copy link
Contributor

lunars97 commented Jul 22, 2024

the colors should definitely be implemented. at the same time, the function of being able to set colors yourself would be super important due to the circumstances described above & should be introduced as soon as possible. do you need a design proposal for this?

it could be implemented like on the example picture below with an input set to color where users can choose colors by their own, @MizukiTemma what do you think?
image

@JoeyStk
Copy link
Contributor Author

JoeyStk commented Jul 22, 2024

Probably also a question for @osmers

@osmers
Copy link

osmers commented Jul 23, 2024

@hauf-toni design proposal would be good bcs I cannot imagine well right now what it would look like - where will the users choose these colors? On the statistics page itself? And will the settings be saved to the specific user? Otherwise it defeats the purpose of having the same colors for every language in every region, right?
And going back to your other point - labeling of language names is already done in the CMS. Is that, what you had in mind?
image

@hauf-toni
Copy link

@osmers the labeling is nicely done, I just wanted to point out the importance of clear labeling at the time. I would be happy to make a design draft for a manual selection of the colors & their location. Should we open a specific issue for that or keep the proposal within this workflow, what works best for you?

@hauf-toni design proposal would be good bcs I cannot imagine well right now what it would look like - where will the users choose these colors? On the statistics page itself? And will the settings be saved to the specific user? Otherwise it defeats the purpose of having the same colors for every language in every region, right? And going back to your other point - labeling of language names is already done in the CMS. Is that, what you had in mind? image

@MizukiTemma
Copy link
Member

If we implement the user-specific color-language setting, I suggest to open another issue with mention to this one.

On the statistics page itself? And will the settings be saved to the specific user? Otherwise it defeats the purpose of having the same colors for every language in every region, right?

Yes, definetely.

@osmers
Copy link

osmers commented Jul 24, 2024

I just wanna add that I wouldn't put the user specific color setting high on our priority list bcs so far we never had any feedback that users could not differentiate the colors in the statistics - and we've been using colors (much less contrasty colors as well) for the last 3 years at least.

@MizukiTemma
Copy link
Member

@osmers
Ok, then shall we implement only new colors for now?

@osmers
Copy link

osmers commented Jul 24, 2024

@MizukiTemma yeah :) but we can create the new issue for the color picker and put it in the backlog

@MizukiTemma
Copy link
Member

Opened #2926
Feel free to modify and correct 😸

@PeterNerlich PeterNerlich modified the milestones: 24Q3, 24Q4 Aug 27, 2024
@nikolahoff
Copy link

@MizukiTemma @JoeyStk I think this ticket is done for UI, right? Or what about the Blocked items:
BLOCKED: Add language colors for Paschto, Uzbek and Macedonian (for Malte)
BLOCKED: Add some buffer language colors for yet unspecified languages

Otherwise I would put it on done

@JoeyStk
Copy link
Contributor Author

JoeyStk commented Sep 9, 2024

@nikolahoff As far as I know we still need the two other blocked items, so the three colors for Malte and then some additional language colors for the future :)

@nikolahoff
Copy link

Here are the additional colours

@JoeyStk
Copy link
Contributor Author

JoeyStk commented Sep 9, 2024

@nikolahoff Thank you very much :) I think ticket is ready for us then :)

@JoeyStk JoeyStk removed question Further information is requested ui-ux Issues that requires an UI/UX perspective. labels Sep 9, 2024
@osmers
Copy link

osmers commented Oct 2, 2024

@JoeyStk @lunars97 can this issue be moved to in progress then?

@JoeyStk
Copy link
Contributor Author

JoeyStk commented Oct 2, 2024

@osmers I don't think that active implementation has been done yet

@JoeyStk JoeyStk modified the milestones: 24Q4, 25Q1 Oct 8, 2024
@juliankehne juliankehne added the tested Was successfully tested on cms-test label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low Should be doable in <4h feature New feature or request good first issue Good for newcomers tested Was successfully tested on cms-test
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

9 participants