Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional language colors #3240

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

lunars97
Copy link
Contributor

Short description

Add additional language colors for Georgian, Slovak, Serbian (cyrillic), Oromo (for integreat) and for Malte (Pashto, Uzbek, and Macedonian) and three colors as a buffer for future use.

Proposed changes

  • Add colors to language colors
  • Define color names according to color picker I chose color names based on HTML color names and the Universal Color Naming System

Side effects

  • none

Resolved issues

Fixes: #2858


Pull Request Review Guidelines

@MizukiTemma MizukiTemma self-requested a review November 26, 2024 09:51
Copy link
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😸 The new colors are there 👍

We should maybe add a release note so Service Team will be notified.

@lunars97 lunars97 force-pushed the feature/add-additional-language-colors branch from 47d775a to ab73d23 Compare November 26, 2024 10:21
Copy link
Member

@david-venhoff david-venhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits

integreat_cms/locale/de/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
integreat_cms/locale/de/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
integreat_cms/locale/de/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
integreat_cms/locale/de/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
@lunars97 lunars97 force-pushed the feature/add-additional-language-colors branch from ab73d23 to 6e61b5c Compare November 27, 2024 08:43
@lunars97 lunars97 force-pushed the feature/add-additional-language-colors branch from 6e61b5c to d5dd193 Compare November 27, 2024 08:47
@lunars97 lunars97 merged commit d64f9d8 into develop Nov 27, 2024
5 checks passed
@lunars97 lunars97 deleted the feature/add-additional-language-colors branch November 27, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional language colors
3 participants