Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2024-11-07] Remove E-mail, phone number and website from POI #3086

Open
Tracked by #2955
MizukiTemma opened this issue Oct 1, 2024 · 3 comments · May be fixed by #3180
Open
Tracked by #2955

[2024-11-07] Remove E-mail, phone number and website from POI #3086

MizukiTemma opened this issue Oct 1, 2024 · 3 comments · May be fixed by #3180
Assignees
@lunars97
Labels
deadline Needs to be fixed in the given time feature New feature or request prio: high Needs to be resolved ASAP.
Milestone
Next-up

Comments

@MizukiTemma
Copy link
Member

MizukiTemma commented Oct 1, 2024 •
edited
Loading

Motivation

Currently POI has three fields for contact information: E-mail, phone number and website. We came to an idea, however, while discussing and implementing contact management system, that those fields/information must be managed in contacts in futur.

Proposed Solution

  • Remove those three fields from POI
  • Adjust ajax POI form poi_box.html (remove Contact details, etc)
  • Remove the collapsible box " Contact details" form the POI form [added on 04.12]
  • Create a migration to create contacts from those poi fields and remove the fields from poi
  • Adjust the api so that it returns the same results (Contacts without title and name could be treated as primary contact, and returned instead of the now removed data)

Alternatives

User Story

Additional Context

Design Requirements
@MizukiTemma MizukiTemma added the feature New feature or request label Oct 1, 2024
This was referenced Oct 1, 2024
Closed
Open
@MizukiTemma MizukiTemma added this to the 24Q4 milestone Oct 1, 2024
@MizukiTemma MizukiTemma changed the title Remove E-mail, phone number and website from POI [7.11.24] Remove E-mail, phone number and website from POI Oct 1, 2024
@MizukiTemma MizukiTemma added prio: high Needs to be resolved ASAP. deadline Needs to be fixed in the given time labels Oct 1, 2024
This was referenced Oct 1, 2024
Closed
Merged
@JoeyStk JoeyStk changed the title [7.11.24] Remove E-mail, phone number and website from POI [2024-11-07] Remove E-mail, phone number and website from POI Oct 4, 2024
@david-venhoff david-venhoff mentioned this issue Oct 31, 2024
Merged
@lunars97 lunars97 self-assigned this Nov 5, 2024
@MizukiTemma
Copy link
Member Author

MizukiTemma commented Nov 6, 2024 •
edited
Loading

As "primary contact" meant is contact objects without "point_of_contact_for". There is a constraint that for each POI max. one primary contact exists (already implemented).

For this issue I have imagined following work steps:

  1. For each POI which has at least one of E-mail, phone number and website, create a contact object with them ("point_of_contact_for" and "name" stay empty).
  2. Remove E-mail, phone number and website fields from POI model.
  3. Remove the box of those three fields from the POI form.
  4. Adjust API so it finds the primary contact of the requested POI and reads those fields from the primary contact.

@lunars97 lunars97 linked a pull request Nov 6, 2024 that will close this issue
Open
6 tasks
@osmers
Copy link

osmers commented Nov 7, 2024

Just one question before this gets closed - didn't we say that this cannot be removed before we have not migrated the information stored there to a general contact?

@david-venhoff
Copy link
Member

Yes, this will be part of this issue:

  • Create a migration to create contacts from those poi fields and remove the fields from poi

Though it looks like it is currently missing from the pr

@JoeyStk JoeyStk modified the milestones: 24Q4, Next-up Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lunars97 lunars97

Labels
deadline Needs to be fixed in the given time feature New feature or request prio: high Needs to be resolved ASAP.
Projects
None yet
Milestone
Next-up
Development

Successfully merging a pull request may close this issue.

Remove contact data fields from poi digitalfabrik/integreat-cms
5 participants
@osmers @JoeyStk @lunars97 @david-venhoff @MizukiTemma