Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prevent early exit of tools/code_style.sh after exit code 1 #3299

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

charludo
Copy link
Contributor

@charludo charludo commented Dec 18, 2024

Short description

Some of the code style tools "fail" with exit code 1 when they performed an action (e.g.: djlint exits with code 1 after changing any file's formatting).

This exits the entire tools/code_style.sh script, and you need to invoke it again.

Proposed changes

  • continue with the next tool, even if the previous one "failed"

Side effects

  • none I think
  • I will stop feeling annoyed by this 😂 😂 😂

Resolved issues

Fixes: n/a


Pull Request Review Guidelines

@charludo charludo added the not-testable Issues that are not testable label Dec 18, 2024
Copy link
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

Copy link
Member

@david-venhoff david-venhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-testable Issues that are not testable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants