-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous Internal Changes #499
base: master
Are you sure you want to change the base?
Changes from all commits
8256ac2
506d9c5
492205b
49de008
77774af
bda7b97
80ecb26
7c832d1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
{ | ||
"compilerOptions": { | ||
"types": ["node"], | ||
"moduleResolution": "node", | ||
"module": "NodeNext", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
"isolatedModules": true, | ||
"checkJs": true, | ||
"allowJs": true, | ||
"noEmit": true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Otherwise, I get an error about it can't output .js files because they're already authored in js. |
||
"strict": true, | ||
"resolveJsonModule": true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It didn't look like this was needed anymore, and latest ts5.7 makes backcompat a pain, so I removed it. |
||
"lib": ["es2015", "es2017.object", "esnext", "dom"] | ||
"lib": ["esnext", "dom"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was getting an error about bad targets & stuff, and this seemed to resolve it. The |
||
}, | ||
"exclude": ["node_modules", "generated"] | ||
} |
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,8 +3,7 @@ | |
"type": "module", | ||
"version": "3.0.17", | ||
"homepage": "https://elm-pages.com", | ||
"moduleResolution": "node", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't a thing. |
||
"description": "Type-safe static sites, written in pure elm with your own custom elm-markup syntax.", | ||
"description": "Hybrid Elm framework with full-stack and static routes.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just took it from the repo description. |
||
"main": "index.js", | ||
"scripts": { | ||
"start": "cd examples/end-to-end && npm i && npx elm-pages dev", | ||
|
@@ -50,12 +49,17 @@ | |
"which": "^5.0.0" | ||
}, | ||
"devDependencies": { | ||
"@types/busboy": "~1.5.4", | ||
"@types/connect": "~3.4.38", | ||
"@types/cookie-signature": "~1.1.2", | ||
"@types/cross-spawn": "^6.0.6", | ||
"@types/fs-extra": "^11.0.4", | ||
"@types/jsesc": "~3.0.3", | ||
"@types/make-fetch-happen": "^10.0.4", | ||
"@types/micromatch": "^4.0.9", | ||
"@types/node": "^22.10.0", | ||
"@types/serve-static": "^1.15.7", | ||
"@types/which": "~3.0.4", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TS was complaining about the lack of types for which, so I ran typesync. |
||
"cypress": "^13.16.0", | ||
"elm-codegen": "^0.6.1", | ||
"elm-optimize-level-2": "^0.3.5", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
"strict": true, | ||
"target": "ESNext", | ||
"module": "NodeNext", | ||
"moduleResolution": "NodeNext" | ||
"moduleResolution": "NodeNext", | ||
"checkJs": true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assumed that you want ts checking of js files, given the jsconfig. |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prevented
@types
packages from working.