Webhook #29
Closed
Webhook #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaapstorm
force-pushed
the
nh/webhook
branch
from
1e41803 to
d77b480
Compare
SmittieC
reviewed
Nov 23, 2023
kaapstorm
force-pushed
the
nh/webhook
branch
from
c7404aa to
52671c9
Compare
`subscribe_to_hq_datasource()` can't be called asynchronously because it needs a web session, so that it can get the OAuth token to authenticate with HQ.
Models use utils. Utils don't use models.
kaapstorm
force-pushed
the
nh/webhook
branch
from
52671c9 to
4aea365
Compare
SmittieC
reviewed
Feb 22, 2024
|
|
||
| Those changes will allow Alembic to connect to the "HD Data" database | ||
| without the need to instantiate Superset's Flask app. You can now | ||
| autogenerate your new table with: |
SmittieC
reviewed
Feb 22, 2024
hq_superset/tasks.py
Outdated
| @@ -16,34 +13,3 @@ def refresh_hq_datasource_task(domain, datasource_id, display_name, export_path, | |||
| AsyncImportHelper(domain, datasource_id).mark_as_complete() | |||
| raise | |||
| os.remove(export_path) | |||
|
|
|||
There was a problem hiding this comment.
From the commit message:
so that it can get the OAuth token to authenticate with HQ.
Speaking out of inexperience in this area, but can't we simply pass the token to the celery task?
There was a problem hiding this comment.
(Just closing the loop here. It needs the request session. We could serialize it and pass it to the task, but something about that feels awkward to me. I'm happy to be educated though. :) )
Not necessary for PostgreSQL
* No need to query for tables. * Can't upsert without an index. Creating an index on doc_id might be useful. Do later. * Use a connection off database, otherwise db.session can't find the table.
Also rename some vars, move func def
|
Closing. This branch has been rebased and can be reviewed at PR #41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start on the API endpoint for making changes to datasets.
The first five commits are only cleanup, and a small refactor to move a function into
utils.pyso that bothtasksandviewsimport fromutils.Create webhook endpoint is the first useful commit. It defines a dataclass for the request payload, and adds the scaffolding for a view for the endpoint.
fyi @Charl1996 @SmittieC