Redirect user to login page when oauth session expired #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkangia
reviewed
Dec 3, 2024
|
|
||
| appbuilder.add_view(views.HQDatasourceView, 'Update HQ Datasource', menu_cond=lambda *_: False) | ||
| appbuilder.add_view(views.SelectDomainView, 'Select a Domain', menu_cond=lambda *_: False) | ||
| appbuilder.add_api(api.OAuth) | ||
| appbuilder.add_api(api.DataSetChangeAPI) | ||
| oauth2_server.config_oauth2(app) | ||
|
|
||
| app.register_error_handler(OAuthSessionExpired, hq_domain.oauth_session_expired) |
There was a problem hiding this comment.
How will this cater to "OAuthError"?
There was a problem hiding this comment.
Haha, I added the OAuthError to be caught but didn't push it. See bae3f7a. Thanks for reminder.
There was a problem hiding this comment.
Thanks. Let me know if you want to test this on staging, I can still replicate it predictably
There was a problem hiding this comment.
Approved, let me know when deployed to staging
There was a problem hiding this comment.
@mkangia It's deployed.
There was a problem hiding this comment.
Great, I can see the message to login again now.
mkangia
approved these changes
Dec 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
We've been having an issue on CCA where users which are already logged in to CCA could not access the site due to a 500 error. The error can be seen below.
This was likely due to the refresh token having expired.
This PR simply adds a way of catching the
OAuthSessionExpiredif it's raised in any of the views and does the following:A simple test has been added to test this behaviour.