Configure skipping data change for domains #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkangia
force-pushed
the
mk/4136-allow-skipping-domains-changes
branch
from
4e03602 to
b322aab
Compare
zandre-eng
approved these changes
Dec 20, 2024
| @@ -41,6 +51,10 @@ def update_dataset(self): | |||
| raise TableMissing(f'{self.data_source_id} table not found.') | |||
| table = sqla_table.get_sqla_table_object() | |||
|
|
|||
| if table.schema and table.schema in SKIP_DATASET_CHANGE_FOR_SCHEMAS: | |||
There was a problem hiding this comment.
Will this then only ignore future dataset changes, or will it also ignore ones that are currently queued?
There was a problem hiding this comment.
Had an offline sync with Manish.
There was a problem hiding this comment.
Offlined that the change will apply to any domains added to config and celery restarted.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A way to configure any domains to be skipped during data source processing.
This would come in handy and I currently need it to skip changes queued for a project I would manually refresh making the changes redundant.