Centralize/Unify Sync and Submit Logic #628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… replications for a serious issue with asynchronous restore processing online
ctsims
commented
Aug 11, 2017
|
|
||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| /** |
There was a problem hiding this comment.
note: This is not a proper unit test, but will be run with the unit tests right now. It should get fixed to run only during some sort of integration test cycle.
|
@ctsims Is this still relevant / something you want to get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of reworks of the testing infrastructure which centralize how syncs and submissions are working.
Submitting forms to the server now works from the CLI, as well as tests, and syncing is now capable of handling significantly more robust outcomes.
Did this to make it possible to test complex sync behaviors to replicate bugs, but long term we should be able to get more aligned on things like what processing paths exist.
Shouldn't pull until we figure out what to do with the replication in here. It shouldn't really be run with the unit tests.
Includes: https://github.com/dimagi/commcare-core/pull/627/files which should be reviewed first just because it's way easier.