Prevent a FD_SET undefined behavior #427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The glic library does a runtime check and abort in this case. See __fdelt_chk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm developing a program that sends e-mails using libetpan and that connects to several servers using libcurl.
It was crashing after a certain amount of time and I painfully debugged it : I was leaking curl handles, leaving open many connections.
In fact, I was hitting a runtime check (__fdelt_chk glibc function) as soon as libetpan was trying to use FD_SET with a socket descriptor above FD_SETSIZE.
This merge request is about preventing an undefined behavior that may be triggered by other users.
I'm also changing optimization level to none because debugging with "optimized out" function parameters and return values is quite challenging.