Trigger stickyChange when attaching viewport #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes an issue in chromium browsers where: -- If the table has a sticky header and stickyPositions is not yet initialized -- And a scrollToIndex is issued to an index outside the current range -- The browser triggers a second scroll event when initializing the sticky elements, possibly messing up the scrolling and not showing the index issued to scrollToIndex
|
@diprokon could you give me an ETA on when this change could be available in a published version? We would like to have this fix available in our application as soon as possible. Thank you :) |
|
@raphael-inglin-ergon I was double checking you fix, and it didn't fix #126 for me :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue in chromium browsers where:
Strangely, the line reading
offsetTopininitStickyPositionsseems to be what is triggering the unwanted scroll. Seems to be some browser specific behavior.Might fix #126 . Confirmation needed.