catch internal links and use router #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for directus-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
components/Base/Text.vue
Outdated
Comment on lines
27
to
51
| onMounted(() => { | ||
| if (!contentEl.value) return; | ||
|
|
||
| // Intercept all the local links | ||
| const anchors = contentEl.value.getElementsByTagName('a'); | ||
| if (!anchors) return; | ||
|
|
||
| Array.from(anchors).forEach((anchor) => { | ||
| const url = anchor.getAttribute('href'); | ||
| if (!url) return; | ||
|
|
||
| // Add target blank to external links | ||
| if (!url.startsWith(config.public.site.url) && !url.startsWith('/')) { | ||
| anchor.setAttribute('target', '_blank'); | ||
| anchor.setAttribute('rel', 'noopener noreferrer'); | ||
| return; | ||
| } else { | ||
| // Add on click event to local links | ||
| anchor.addEventListener('click', (e) => { | ||
| e.preventDefault(); | ||
| navigateTo(url); | ||
| }); | ||
| } | ||
| }); | ||
| }); |
There was a problem hiding this comment.
This is one of those It works but man I wish there was a less hacky way to achieve this
There was a problem hiding this comment.
Yeah me too. Couldn't come up with any "simple" solutions.
Open to suggestions.
I think the proper way would be to use some type of transformer to process the HTML during the build process.
There was a problem hiding this comment.
That would be the only alternative yeah, but even then we can't really replace it with <nuxt-route> as nuxt wouldn't be able to recognize that 🤔
In case the navigate fails
rijkvanzanten
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One issue for the WYSIWYG editor is internal links from resources / blogs etc - right now it would cause a full page reload. This should fix that and also open external links in a new tab.
Notes: