Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Og Images Take #2 #75

Merged
merged 10 commits into from
Sep 27, 2023
Merged

Og Images Take #2 #75

merged 10 commits into from
Sep 27, 2023

Conversation

bryantgillespie
Copy link
Member

Satori edition 😆

@netlify
Copy link

netlify bot commented Sep 20, 2023 •
edited
Loading

✅ Deploy Preview for directus-website ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/directus-website/deploys/650b6e969ee1d25d4e509fef
😎 Deploy Preview https://deploy-preview-75--directus-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bryantgillespie
Copy link
Member Author

SUCCESS 🙌
Looks like we found the magic combo of dependencies to make this work.

Only one caveat -
If you post the links to the deploy preview the image is broken because it points to directus.io instead of /deploy-preview-75--directus-website.netlify.app
But should work fine when merged in main

@bryantgillespie bryantgillespie marked this pull request as ready for review September 20, 2023 21:36
@bryantgillespie bryantgillespie mentioned this pull request Sep 20, 2023
Closed
@rijkvanzanten rijkvanzanten self-assigned this Sep 21, 2023
@bryantgillespie
Copy link
Member Author

@rijkvanzanten Did you have any changes or anything for this?
Would be great to have those og images for SEO.

rijkvanzanten
rijkvanzanten approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@rijkvanzanten rijkvanzanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have the time to review this in-depth, but seeing the high value and low risk (we can always revert if things go 💥) lets ship it!

@rijkvanzanten rijkvanzanten merged commit f7c4f78 into main Sep 27, 2023
5 checks passed
@rijkvanzanten rijkvanzanten deleted the og-take2 branch September 27, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rijkvanzanten rijkvanzanten rijkvanzanten approved these changes

Assignees

@rijkvanzanten rijkvanzanten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantgillespie @rijkvanzanten