fix(ops): output single frame before evaluating encode timeout #201
+82
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waldeedle
force-pushed
the
fix/single-frame-from-animated-images
branch
from
9094729 to
46d3d2d
Compare
|
@skidder this one should be fairly quick to dismiss or accept 🙏 |
skidder
reviewed
Nov 19, 2024
Waldeedle
force-pushed
the
fix/single-frame-from-animated-images
branch
from
46d3d2d to
15cf55b
Compare
skidder
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was updating some legacy code and testing new lilliput capabilities I realized that the single frame generation work is done but due to how the
DisableAnimatedOutputoption is evaluated at the start of the loop, I was getting theErrEncodeTimeoutwhen not specifying a encoding timeout.The relevant test has been added with a timeout of 0 and the other tests have 300 specified to continue to operate as they are today.