DGI9-584: Feature/pgsql locking #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hexdec()` is not quite the "cast" that was desired, directly converting 64 bits to an integer such that negative values could be created. Instead let's drop to a signed 60 bit integer (using 61 bits). ~2^61 IDs should allow for plenty of space for things to spread out.
If there had been a collision between a "migration" lock and the control lock, the release of the control lock after acquiring the migration locks would have lead to the colliding migration lock to dropped in the pgsql_advisory_locking implementation.
…ature/pgsql-locking
We can still use it if desired, but let's have it be more explicitly selected.
|
Just for reference: 7f4f4da is addressing https://discoverygarden.atlassian.net/browse/DDST-866 |
…ature/pgsql-locking
jordandukart
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.