Allow Local instances to be cleared without deleting #385
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ababic
force-pushed
the
clearable-locals
branch
from
a81e5c3 to
bf84d7b
Compare
andrewgodwin
approved these changes
Apr 25, 2023
|
I like the idea, but like anything that touches Local, it looks like the tests need a bit more attention! |
|
Thanks @andrewgodwin. I was previously relying on the CI to see test results, but I'll get things setup here properly and ensure tests are all ship-shape before requesting a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings, lovely people!
I'm in the process of using
Localin a couple of projects, and recently had a case where I wanted to clear cached values based on certain signals, without deleting the object completely.I'm sure you'll agree the changes are super simple, but I feel this tiny change brings the API more in-line with other familiar cache options, and may help with adoption.
Thank you for all the wonderful work so far, folks.