Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the command name docker-compose to docker compose #236

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

nakul-py
Copy link
Contributor

@nakul-py nakul-py commented Dec 5, 2024

Switching to docker compose instead of docker-compose

closes #235

Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! 🎸

Everything looks perfect, except for that one line that I think can be removed instead of changed (I left a specific comment for it).

You can either make the suggested change in a separate commit, or amend the existing commit and force-push. Do what you're most confortable with and I'll figure out the merging.

Thanks!

README.rst Outdated Show resolved Hide resolved
@nakul-py nakul-py force-pushed the docker-compose-command branch from fe366a3 to 4ef95b6 Compare December 5, 2024 12:30
@nakul-py nakul-py closed this Dec 5, 2024
@nakul-py nakul-py force-pushed the docker-compose-command branch from 4ef95b6 to 45b7589 Compare December 5, 2024 12:34
@nakul-py nakul-py deleted the docker-compose-command branch December 5, 2024 12:35
@nakul-py nakul-py restored the docker-compose-command branch December 5, 2024 12:36
@nakul-py nakul-py reopened this Dec 5, 2024
@nakul-py
Copy link
Contributor Author

nakul-py commented Dec 5, 2024

41e5411 This commit will close this issue.

@nakul-py nakul-py requested a review from bmispelon December 5, 2024 12:41
Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

Thanks for the quick update on this, I will merge the pull request soon.

Have a nice day! 🎸

@bmispelon bmispelon merged commit 14341a9 into django:main Dec 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to docker compose instead of docker-compose
2 participants