Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1686 -- Remove reference to Django core team #1735

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

ontowhee
Copy link
Contributor

@ontowhee ontowhee commented Nov 13, 2024

Fix for #1686

Removed references to the "core team" on the pages "Code Of Conduct - Changes" and "Diversity - Changes".

Before:
Screenshot 2024-11-13 at 11 19 17 AM

After:
Screenshot 2024-11-13 at 11 19 40 AM

Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thanks for looking into this.

I think the wording can be further simplified, I've left some suggestions. Let me know what you think 🎸

Comment on lines 19 to 20
We'll hold a comment period of at least one week, and then each group will vote
on the change using its normal process (a board for the DSF,
<a href="{% url 'document-detail' lang='en' version='dev' url='internals/contributing/bugs-and-features' host 'docs' %}#how-we-make-decisions">
a core dev vote</a> for the core team).
on the change using its normal process (a board for the DSF).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sentence can be simplified now, maybe something like:

We'll hold a comment period of at least one week, then the DSF board will vote on the change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I agree, it is much simpler now. It was awkward with just one group mentioned in the parenthesis.

Comment on lines 17 to 18
We'll hold a comment period of at least one week, and then each group will vote
on the change using its normal process (a board for the DSF,
<a href="{% url 'document-detail' lang='en' version='dev' url='internals/contributing/bugs-and-features' host 'docs' %}#how-we-make-decisions">
a core dev vote</a> for the core team).
on the change using its normal process (a board for the DSF).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

@ontowhee ontowhee requested a review from bmispelon November 13, 2024 20:14
@bmispelon bmispelon merged commit a85969a into django:main Nov 13, 2024
4 checks passed
@bmispelon
Copy link
Member

Excellent work, thank you 👍🏻
(The change should be deployed within the hour)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants