Retain mesh and property into separate components #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retain the mesh and the properties of an effect instance into separate components (namely, `CachedMesh` and `CachedProperties`). Directly process effect instances from extracted data, instead of inserting a modified representation (batch input) and processing that. This simplify the code and removes some unnecessary copies. Split the batching operation (which currently doesn't batch anything) into a separate `batch_effects()` system, which reads all the cached effects directly from the ECS world, after `prepare_effects()` updated them from the extracted ones.
djeedai
added
C - enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retain the mesh and the properties of an effect instance into separate components (namely,
CachedMeshandCachedProperties).Directly process effect instances from extracted data, instead of inserting a modified representation (batch input) and processing that. This simplify the code and removes some unnecessary copies.
Split the batching operation (which currently doesn't batch anything) into a separate
batch_effects()system, which reads all the cached effects directly from the ECS world, afterprepare_effects()updated them from the extracted ones.