Always define ldap servers using multiple server lines

[treydock]

Using freeradius-3.0.13-9.el7_5.x86_64 I get this in logs:

Tue Oct 30 12:18:23 2018 : Warning: Listing multiple LDAP servers in the 'server' configuration item is deprecated and will be removed in a future release.  Use multiple 'server' configuration items instead

[djjudas21]

Thanks, I see what you're trying to do, in general I approve, but there's a reason this was necessary.

Is your package from the official CentOS repos? As I recall, both CentOS and Ubuntu backport components from FreeRADIUS 3.1.x into their 3.0.x packages, which causes this warning. However if you build FreeRADIUS 3.0.x from vanilla source (which is what I was using) then the newer multi-line syntax is not supported and the daemon will fail to start.

The way the code stands today, you get deprecation warnings but not an actual error so at least it is "safe".

So, before I'm willing to accept this PR I'd need to see a test case that your patch doesn't break vanilla FreeRADIUS 3.0.x. I would test myself but unfortunately I've changed jobs and I no longer work with FreeRADIUS or CentOS. Is this something you could do?