Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix params_empty_string_assignment of freeradius::radsniff::options #208

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix params_empty_string_assignment of freeradius::radsniff::options #208

wants to merge 1 commit into from

Conversation

cruelsmith
Copy link
Contributor

@cruelsmith cruelsmith commented Aug 18, 2023 •
edited
Loading

Pull Request (PR) description

  • Fix params_empty_string_assignment of freeradius::radsniff::options
  • Removes useless "Calculating" definitions
    • Puppet itself fail with wrong parameter type (undef != String) if no value comes has been provided via class call or from params. The default lookup order is parameter from class call, hiera lookup and then default class value what is here the params value.

This Pull Request (PR) fixes the following issues

None

@cruelsmith cruelsmith mentioned this pull request Aug 18, 2023
Open
@jorhett
Copy link
Contributor

jorhett commented Sep 7, 2024

This seems better and the final change is much more readable... @djjudas21 any reason not to implement this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cruelsmith @jorhett