fix #20621 Comparing addresses of rvalue reference parameters not cor…

[WalterBright]

…rect

#20621

[dlang-bot]

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

• In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20622"

[WalterBright]

As usual, this does not fail in the test suite. It fails compiling druntime, which is done before the test suite, so of course it means a lot of work to try to isolate the problem. How can I emphasize the test suite should be run first, not last? The error:

core.exception.AssertError@src\dmd\backend\inliner.d(519): Assertion failure
el:0F2B0950 cnt=0 rpair TYulong 0F2AD980 14691C98
 el:0F2AD980 cnt=0 relconst TY*  0+& __B6C5897553EA1E3D4639405AE120F017
 el:14691C98 cnt=0 const TYuint 34L 

[WalterBright]

Thanks, @thewilsonator !

[thewilsonator]

No problem. Btw could you take a look at #20277 when you get the chance.