Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopulationStatistic의 DashboareType에 따라 DashboareComponent 생성 #115

Open
wants to merge 5 commits into
base: refactor/#104
Choose a base branch
from

Conversation

eun-seong
Copy link
Member

@eun-seong eun-seong commented Mar 6, 2024

이 PR은 #113 이 머지된 후 머지됩니다.

요약

PopulationStatistic의 DashboareType에 따라 DashboareComponent 생성하도록 수정하였습니다.

변경된 점

  • 유저 통계와 전체 통계 분리 리팩토링(#104) #113 에서 BorroingLimiStatistic -> AverageEntireStatistic으로 변경되었고
  • borrowingLimitStatistic으로 하드코딩되어 있던 부분을 드러내었습니다.
  • EntireStatistic 구현체를 부모 클래스에서 수행하도록하기 위해 interface에서 추상 클래스로 변경되었습니다.

@eun-seong eun-seong force-pushed the refactor/#114 branch 2 times, most recently from 0a92e18 to 466774e Compare March 6, 2024 18:56
@eun-seong eun-seong changed the title Refactor/#114 BorrowingLimitStatistic을 AverageEntireStatistic으로 변경 Mar 7, 2024
@eun-seong eun-seong changed the title BorrowingLimitStatistic을 AverageEntireStatistic으로 변경 PopulationStatistic의 DashboareType에 따라 DashboareComponent 생성 Mar 7, 2024
@eun-seong eun-seong requested a review from rlacksgus97 March 7, 2024 09:27
@eun-seong eun-seong self-assigned this Mar 7, 2024
@eun-seong eun-seong marked this pull request as ready for review March 7, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants