Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: JpaRunningRecordRepository.findByMemberIdAndStartAtBetween 메서드에서 member 테이블을 fetch join하도록 수정 #267

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix: JpaRunningRecordRepository.findByMemberIdAndStartAtBetween 메서드에서 member 테이블을 fetch join하도록 수정 #267

merged 1 commit into from
Oct 15, 2024

Conversation

Jaewon-pro
Copy link
Member

🔗 이슈 연결

🚀 구현한 API

  • X

💡 반영할 내용 및 변경 사항 요약

  • 기존에는 러닝 기록 조회 시 마다 member 테이블을 다시 조회합니다. (N + 1 문제)
  • 이 PR에서는 JpaRunningRecordRepository.findByMemberIdAndStartAtBetween() 메서드에서 member 테이블을 fetch join하도록 수정합니다.

🔍 리뷰 요청/참고 사항

@Jaewon-pro Jaewon-pro self-assigned this Oct 15, 2024
@Jaewon-pro Jaewon-pro requested a review from hee9841 October 15, 2024 02:00
hee9841
hee9841 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@hee9841 hee9841 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jaewon-pro Jaewon-pro merged commit 9114a4b into main Oct 15, 2024
1 check passed
@Jaewon-pro Jaewon-pro deleted the fix/#265/running-record-member-fetch-join branch October 15, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hee9841 hee9841 hee9841 approved these changes

Assignees

@Jaewon-pro Jaewon-pro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

구간 내 러닝 기록 조회 시, member 테이블을 따로 다시 조회하는 문제
2 participants
@Jaewon-pro @hee9841