Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: 나의 기록 뱃지 조회를 최신 기준으로 최대 3개 리턴하도록 수정 #288

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Fix: 나의 기록 뱃지 조회를 최신 기준으로 최대 3개 리턴하도록 수정 #288

merged 3 commits into from
Oct 29, 2024

Conversation

hee9841
Copy link
Collaborator

@hee9841 hee9841 commented Oct 29, 2024

🔗 이슈 연결

🚀 구현한 API

  • GET /api/v1/badges/me

💡 반영할 내용 및 변경 사항 요약

  • 나의 기록의 뱃지 리스트 조회 시, 획득한 날짜 최신 기준으로 최대 3개를 리턴하도록 변경합니다.
    • 조회 쿼리를 최신 기준으로 order by후 3개만 조회하도록 변경합니다.
    • BadgeAchievementRepository의 findByMemberIdWithBadge함수명을 좀 더 명확한 findByMemberIdWithBadgeOrderByAchievedAtLimit로 변경합니다.

🔍 리뷰 요청/참고 사항

@hee9841 hee9841 self-assigned this Oct 29, 2024
@hee9841 hee9841 changed the title Fix/#285/badges me Fix: 나의 기록 뱃지 조회를 최신 기준으로 최대 3개 리턴하도록 수정 Oct 29, 2024
@hee9841 hee9841 requested a review from Jaewon-pro October 29, 2024 07:18
Jaewon-pro
Jaewon-pro approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@Jaewon-pro Jaewon-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@hee9841 hee9841 merged commit 1c4fada into main Oct 29, 2024
1 check passed
@hee9841 hee9841 deleted the fix/#285/badges-me branch October 30, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaewon-pro Jaewon-pro Jaewon-pro approved these changes

Assignees

@hee9841 hee9841

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

나의기록 뱃지 최신 기준으로 갯수 3개로 응답하게 수정
2 participants
@hee9841 @Jaewon-pro