Refactor: 달성 기록 API v1 리팩터링 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 서비스 단에서 전체 코스 리스트(달성한, 달성하지 않은, 현재) 및 달성 기록의 정보를 리턴하도록 구현(CoursesDto 반환) - 바뀐 서비스 단에 맞게 서비스 재 구성 - ScaleCoursesResponse 및 ScaleControllerV1에서 데이터 가공
Jaewon-pro
approved these changes
Nov 19, 2024
| * (ex. 2코스라면, 1코스 totalMeter + 2코스 totalMeter의 값) | ||
| * @param achievedAt 달성한 날짜, 달성하지 않으면 null | ||
| */ | ||
| @Schema(name = "course", description = "코스") |
There was a problem hiding this comment.
application 계층에 있는 dto 클래스는 스웨거(컨트롤러 계층)이 없어야 할 것 같아요!
There was a problem hiding this comment.
V2 만드는 PR에 해당 부분 수정해서 올릴게요!
| import static org.mockito.BDDMockito.given; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| class ScaleControllerTest { |
There was a problem hiding this comment.
ControllerTest의 경우에는 Mockito로 하기 보다는 mock mvc로 하면 좋을 것 같아요
이것도 예제를 추가하려 했는데, 환경 설정 작업량이 많아져서 제가 별도의 이슈에서 처리하면 좋을 것 같아요
일단 이 테스트로 하고, 제가 추후 작업에서 mock mvc를 이용해 테스트하도록 수정하면 어떨까요?
There was a problem hiding this comment.
다음 회의 때 mock mvc로 사용하자고 이야기할려고 했었는데!
좋습니다 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 이슈 연결
🚀 구현한 API
/api/v1/scale/course💡 반영할 내용 및 변경 사항 요약
getAchievements함수를 변경합니다.ScaleCoursesResponse에서 처리합니다.🔍 리뷰 요청/참고 사항