Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix #99] CORS 중복 Bean 제거 #100

Merged
merged 4 commits into from
Sep 6, 2024
Merged

[fix #99] CORS 중복 Bean 제거 #100

merged 4 commits into from
Sep 6, 2024

Conversation

dudxo
Copy link
Collaborator

@dudxo dudxo commented Sep 5, 2024

관련 이슈

📑 작업 상세 내용

  • CORS 중복 Bean 제거

💫 작업 요약

  • CORS 중복 Bean 제거

🔍 중점적으로 리뷰 할 부분

@dudxo dudxo added the 🚨 fix 오류 수정 label Sep 5, 2024
@dudxo dudxo self-assigned this Sep 5, 2024
@dudxo dudxo linked an issue Sep 5, 2024 that may be closed by this pull request
🚨 CORS 중복 Bean 해결 #99
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Code Coverage

Overall Project 84.48% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

Test Results

 23 files   23 suites   16s ⏱️
104 tests 104 ✅ 0 💤 0 ❌
105 runs  105 ✅ 0 💤 0 ❌

Results for commit 82c49a8.

♻️ This comment has been updated with latest results.

@dudxo dudxo mentioned this pull request Sep 5, 2024
Merged
@hyun2371 hyun2371 self-requested a review September 6, 2024 02:28
hyun2371
hyun2371 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@hyun2371 hyun2371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다!

@dudxo dudxo merged commit 139e524 into dev Sep 6, 2024
3 checks passed
@dudxo dudxo deleted the fix/#99/duplicated-cors-bean branch September 6, 2024 04:43
dudxo added a commit that referenced this pull request Sep 6, 2024
@dudxo
[refactor #100] oauth kakao login refactor (#102)
c734e0f 
* [refactor] : Member role 필드 생성으로 인해 불필요해진 Auth 객체 및 관련 클래스, 메서드 삭제

* [rename] : Provider 파일 경로 수정(auth.domain -> member.domain)

* [style] : 안쓰는 예외 throws 제거

* [style] : AuthService 의존성 제거

* [style] : 안쓰는 예외 throws 제거

* [test] : Auth 관련 삭제로 인한 불필요한 테스트 코드 제거

* [refactor] : KakaoRespons.provider을 상수로 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyun2371 hyun2371 hyun2371 approved these changes

Assignees

@dudxo dudxo

Labels
🚨 fix 오류 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚨 CORS 중복 Bean 해결
2 participants
@dudxo @hyun2371