[refactor #104] 알림 생성 API Refactor #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
dudxo
changed the title
Code Coverage
|
Test Results 23 files 23 suites 12s ⏱️ Results for commit e21637b. ♻️ This comment has been updated with latest results. |
hyun2371
approved these changes
Sep 13, 2024
| Notification notification = Notification.of(type, targetId, triggerMemberId, toMember); | ||
| @EventListener | ||
| @TransactionalEventListener(phase = TransactionPhase.AFTER_COMMIT) | ||
| @Transactional(propagation = Propagation.REQUIRES_NEW) |
There was a problem hiding this comment.
찾아보니까 두 어노테이션의 성격이 상반된 것 같은데 같이 사용하면 어떻게 동작하는지 궁금합니다!
- EventListener: 트랜잭션에 의존하지 않고, 이벤트 발생 시 즉시 처리
- TransactionalEventListener: 트랜잭션 결과에 따라 이벤트 처리
There was a problem hiding this comment.
확인해보니 중복 어노테이션을 작성했었네요.
잘 몰랐던 부분인데 짚어주셔서 감사합니다!
src/main/java/com/dnd/gongmuin/notification/service/NotificationService.java
Show resolved
Hide resolved
| Long targetId, | ||
| Long triggerMemberId, | ||
| Member toMember | ||
| ) { |
There was a problem hiding this comment.
개인적으로 toMember를 targetMember로 네이밍해도 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
📑 작업 상세 내용
💫 작업 요약
🔍 중점적으로 리뷰 할 부분