Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat #119] 채팅방 상세조회 API #120

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Conversation

hyun2371
Copy link
Member

관련 이슈

📑 작업 상세 내용

  • 채팅방 상세 조회 API
    • answerer, inquirer 판단해 상대방 정보 넘겨줌
    • 채팅방 생성과 동일한 응답 사용

💫 작업 요약

  • 채팅방 상세 조회 API

🔍 중점적으로 리뷰 할 부분

  • 추후에 parameterized test를 통해 중복되는 테스트 코드를 리팩토링 해볼까 생각중입니다..

@hyun2371 hyun2371 added the ✨ feat 기능 추가 label Sep 27, 2024
@hyun2371 hyun2371 requested a review from dudxo September 27, 2024 01:06
@hyun2371 hyun2371 self-assigned this Sep 27, 2024
@hyun2371 hyun2371 linked an issue Sep 27, 2024 that may be closed by this pull request
3 tasks
Copy link

Code Coverage

Overall Project 85.42% 🍏
Files changed 100% 🍏

File Coverage
ChatRoomController.java 100% 🍏
ChatRoomService.java 86.3% 🍏

Copy link

Test Results

 23 files   23 suites   14s ⏱️
112 tests 112 ✅ 0 💤 0 ❌
113 runs  113 ✅ 0 💤 0 ❌

Results for commit aa58794.

Copy link
Collaborator

@dudxo dudxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@hyun2371 hyun2371 merged commit 66a1ce8 into dev Sep 27, 2024
3 checks passed
@hyun2371 hyun2371 deleted the feat/#119/get-chat-room-detail branch September 27, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feat 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ 채팅방 상세조회 API
2 participants