Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat #115] 채팅 신청/수락/거절 알림 API #124

Merged
merged 5 commits into from
Sep 30, 2024
Merged

[feat #115] 채팅 신청/수락/거절 알림 API #124

merged 5 commits into from
Sep 30, 2024

Conversation

dudxo
Copy link
Collaborator

@dudxo dudxo commented Sep 30, 2024

관련 이슈

📑 작업 상세 내용

  • 채팅 생성 시 신청 알림 생성(to. ChatRoom.answerer, from ChatRoom.inquirer)
    • 채팅방 생성 시 알림 생성을 위한 로직 리팩토링
  • 채팅 수락 시 수락 알림 생성(to. ChatRoom.inquirer, from ChatRoom.answerer)
  • 채팅 거절 시 거절 알림 생성(to. ChatRoom.inquirer, from ChatRoom.answerer)

💫 작업 요약

  • 채팅 신청/수락/거절 알림 API

🔍 중점적으로 리뷰 할 부분

  • 채팅방 생성 시 알림 생성을 위한 로직 리팩토링

@dudxo dudxo added the ✨ feat 기능 추가 label Sep 30, 2024
@dudxo dudxo requested a review from hyun2371 September 30, 2024 11:08
@dudxo dudxo self-assigned this Sep 30, 2024
@dudxo dudxo linked an issue Sep 30, 2024 that may be closed by this pull request
✨ 채팅방 요청/수락여부 알림 API #115
Closed
1 task
@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 86.52% 🍏
Files changed 100% 🍏

File Coverage
ChatRoomService.java 92.34% 🍏
NotificationType.java 91.94% 🍏

@github-actions GitHub Actions
Copy link

Test Results

 25 files   25 suites   16s ⏱️
118 tests 118 ✅ 0 💤 0 ❌
119 runs  119 ✅ 0 💤 0 ❌

Results for commit ac3765b.

hyun2371
hyun2371 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@hyun2371 hyun2371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다~

@dudxo dudxo merged commit 32c36f1 into dev Sep 30, 2024
3 checks passed
@dudxo dudxo deleted the feat/#115/chat-notification branch September 30, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyun2371 hyun2371 hyun2371 approved these changes

Assignees

@dudxo dudxo

Labels
✨ feat 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ 채팅방 요청/수락여부 알림 API
2 participants
@dudxo @hyun2371