Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat #130] 채팅 크레딧 내역 추가 #131

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

hyun2371
Copy link
Member

@hyun2371 hyun2371 commented Oct 9, 2024

관련 이슈

📑 작업 상세 내용

  • 기존에 누락된 크레딧 내역 저장 로직 추가
    • 채팅 요청, 채팅 수락, 채팅 거절
  • 채팅 생성(요청) API 응답값에 질문자의 잔여 크레딧 필드 추가
    • 통합 테스트 응답값 검증 추가
    • 채팅 생성 응답과 채팅방 상세조회 응답 분리

💫 작업 요약

  • 채팅 관련 creditHistory 저장 로직 추가

🔍 중점적으로 리뷰 할 부분

@hyun2371 hyun2371 added the ✨ feat 기능 추가 label Oct 9, 2024
@hyun2371 hyun2371 requested a review from dudxo October 9, 2024 13:30
@hyun2371 hyun2371 self-assigned this Oct 9, 2024
@hyun2371 hyun2371 linked an issue Oct 9, 2024 that may be closed by this pull request
1 task
Copy link

github-actions bot commented Oct 9, 2024

Code Coverage

Overall Project 86.54% 🍏
Files changed 100% 🍏

File Coverage
ChatRoomController.java 100% 🍏
CreditHistoryService.java 100% 🍏
ChatRoomService.java 92.7% 🍏
CreditType.java 76.54% 🍏

@hyun2371 hyun2371 changed the title [feat] : 채팅 크레딧 내역 추가 [feat #130] : 채팅 크레딧 내역 추가 Oct 9, 2024
@hyun2371 hyun2371 changed the title [feat #130] : 채팅 크레딧 내역 추가 [feat #130] 채팅 크레딧 내역 추가 Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Test Results

 25 files   25 suites   15s ⏱️
119 tests 119 ✅ 0 💤 0 ❌
120 runs  120 ✅ 0 💤 0 ❌

Results for commit 6bd4b8e.

Copy link
Collaborator

@dudxo dudxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

QuestionPost questionPost = getQuestionPostById(request.questionPostId());
Member answerer = getMemberById(request.answererId());

ChatRoom chatRoom = chatRoomRepository.save(
ChatRoomMapper.toChatRoom(questionPost, inquirer, answerer)
);

creditHistoryService.saveChatCreditHistory(CreditType.CHAT_REQUEST, inquirer);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 크레딧 관련 코드가 빠졌었군요.. 저도 놓쳤네요

@hyun2371 hyun2371 merged commit 5c5a672 into dev Oct 10, 2024
3 checks passed
@hyun2371 hyun2371 deleted the feat/#130/chat-credit-history branch October 10, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feat 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ 채팅 크레딧 내역 추가
2 participants